chore: remove unused preview providers with NotImplementedError stubs#1256
Merged
Elforama merged 1 commit intoGreenstand:masterfrom Apr 5, 2026
Merged
Conversation
PreviewUtils.previewSharedPrefs and LanguagePickerPreviewProvider were
defined with TODO("Not yet implemented") throughout, but never
referenced via @PreviewParameter annotations or anywhere else in the
codebase. Removing since they were dead code.
Closes Greenstand#1233
Contributor
|
Great work! |
Contributor
Author
Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per the suggested fix in #1233: removed the two preview-provider stubs since neither is referenced anywhere.
PreviewUtils.previewSharedPrefs— no usages in the codebaseLanguagePickerPreviewProvider— never referenced via@PreviewParameterannotationBoth were full of
TODO("Not yet implemented")that would throwNotImplementedErrorif ever hit. Grepped for@PreviewParameteracrossapp/srcand found zero annotations using either class, so they're safe to delete.Closes #1233