Extract hardcoded notification channel strings to NotificationConstants#1252
Conversation
|
@qorexdev thank you for the new pr . |
35070ae to
6e71ecd
Compare
|
rebased on master, no conflicts. should be good now |
|
@qorexdev please keep it up to date, till someone get to review it . thank you |
6e71ecd to
66743b4
Compare
|
rebased on latest master, all clean |
|
@qorexdev you should run |
still needed as generic type param for OneTimeWorkRequestBuilder
|
good call, I looked into the CI failures — turns out I accidentally removed the TreeSyncWorker import in DashboardViewModel (still needed as a type param for the work request builder). Fixed and pushed, should pass now. I don't have an Android SDK setup locally to run codeAnalysis.sh, so I'll keep an eye on CI instead. Let me know if anything else comes up |
open terminal in the root of the project and run this: |
|
thanks for the instructions! I'll set up the Android SDK and try running it before the next push |
Moved hardcoded notification channel ID and name strings into a dedicated NotificationConstants object for easier maintenance and consistency.
Closes #1248