Skip to content

Extract hardcoded notification channel strings to NotificationConstants#1252

Merged
Elforama merged 3 commits intoGreenstand:masterfrom
qorexdev:fix/notification-constants
Apr 5, 2026
Merged

Extract hardcoded notification channel strings to NotificationConstants#1252
Elforama merged 3 commits intoGreenstand:masterfrom
qorexdev:fix/notification-constants

Conversation

@qorexdev
Copy link
Copy Markdown
Contributor

@qorexdev qorexdev commented Apr 4, 2026

Moved hardcoded notification channel ID and name strings into a dedicated NotificationConstants object for easier maintenance and consistency.

Closes #1248

@Tarek-Bohdima
Copy link
Copy Markdown
Member

@qorexdev thank you for the new pr .
can you rebase on master and resolve any conflicts if any?

@qorexdev qorexdev force-pushed the fix/notification-constants branch from 35070ae to 6e71ecd Compare April 4, 2026 15:11
@qorexdev
Copy link
Copy Markdown
Contributor Author

qorexdev commented Apr 4, 2026

rebased on master, no conflicts. should be good now

@Tarek-Bohdima
Copy link
Copy Markdown
Member

Tarek-Bohdima commented Apr 5, 2026

@qorexdev please keep it up to date, till someone get to review it . thank you

@qorexdev qorexdev force-pushed the fix/notification-constants branch from 6e71ecd to 66743b4 Compare April 5, 2026 04:11
@qorexdev
Copy link
Copy Markdown
Contributor Author

qorexdev commented Apr 5, 2026

rebased on latest master, all clean

@Tarek-Bohdima Tarek-Bohdima requested a review from Elforama April 5, 2026 04:25
@Tarek-Bohdima
Copy link
Copy Markdown
Member

@qorexdev you should run codeAnalysis.sh before you commit and push the code , let me know if you need any help with that.

still needed as generic type param for OneTimeWorkRequestBuilder
@qorexdev
Copy link
Copy Markdown
Contributor Author

qorexdev commented Apr 5, 2026

good call, I looked into the CI failures — turns out I accidentally removed the TreeSyncWorker import in DashboardViewModel (still needed as a type param for the work request builder). Fixed and pushed, should pass now.

I don't have an Android SDK setup locally to run codeAnalysis.sh, so I'll keep an eye on CI instead. Let me know if anything else comes up

@Tarek-Bohdima
Copy link
Copy Markdown
Member

good call, I looked into the CI failures — turns out I accidentally removed the TreeSyncWorker import in DashboardViewModel (still needed as a type param for the work request builder). Fixed and pushed, should pass now.

I don't have an Android SDK setup locally to run codeAnalysis.sh, so I'll keep an eye on CI instead. Let me know if anything else comes up

open terminal in the root of the project and run this:
chmod +x codeAnalysis.sh
./codeAnalysis.sh

@qorexdev
Copy link
Copy Markdown
Contributor Author

qorexdev commented Apr 5, 2026

thanks for the instructions! I'll set up the Android SDK and try running it before the next push

@Elforama Elforama merged commit 36b074f into Greenstand:master Apr 5, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extract hardcoded notification channel strings to constants

3 participants