Skip to content

(frontend): Incremental migration to svelte 5 #2755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

(frontend): Incremental migration to svelte 5 #2755

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
d7bb146
Phase 1: bump svelte version and opt in to runes mode
sm17p Jun 16, 2025
cf7e255
phase 2: update bindings to svelte 5 for files in runesGlob
sm17p Jun 18, 2025
476fd0a
phase 3: runes mode for all
sm17p Jun 26, 2025
f99b2d9
fix(DropdownInput): return the index of entry instead of object refer…
sm17p Jun 26, 2025
1bf89ca
Phase 4: removes svelte/legacy compat APIs
sm17p Jun 26, 2025
5f9cbb5
fix: make widget class properties reactive
sm17p Jun 26, 2025
7534cf1
fix: make document context reactive
sm17p Jun 27, 2025
dce421c
fix: conditionally deserialize b/w POJO and class instance for diff u…
sm17p Jun 27, 2025
50b7c1c
fix(ReferencePoint): handle target selection via event delegation for…
sm17p Jun 28, 2025
285413d
perf: create node values loopkup index once per update
sm17p Jun 28, 2025
9c5804f
fix(NodeCatalog): supress reactivity by freezing nodetypes
sm17p Jun 28, 2025
1e2dd32
fix: only trigger change from button
gitbutler-client Jun 29, 2025
200e6e8
refactor(Graph.svelte): use snippets for ports
sm17p Jul 6, 2025
ec88f41
lint: revert eslint-plugin-svelte to v2 and fix lint errors
sm17p Jul 12, 2025
69f6f57
fix: temp editing for field input by adding local reactive state
sm17p Jul 12, 2025
6ac1736
fix: dropdown input reset state on hover out
sm17p Jul 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions frontend/.eslintrc.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ module.exports = {
parserOptions: {
ecmaVersion: "latest",
project: "./tsconfig.json",
extraFileExtensions: [".svelte"],
extraFileExtensions: [".svelte", ".svelte.ts"],
},
ignorePatterns: [
// Ignore generated directories
Expand All @@ -33,7 +33,7 @@ module.exports = {
],
overrides: [
{
files: ["*.svelte"],
files: ["*.svelte", "*.svelte.ts"],
parser: "svelte-eslint-parser",
// Parse the `<script>` in `.svelte` as TypeScript by adding the following configuration.
parserOptions: { parser: "@typescript-eslint/parser" },
Expand All @@ -53,6 +53,9 @@ module.exports = {
"max-len": ["error", { code: 200, tabWidth: 4, ignorePattern: `d="([\\s\\S]*?)"` }],
"prefer-destructuring": "off",
"no-console": "warn",
// eslint recommended for ts project
// https://typescript-eslint.io/troubleshooting/faqs/eslint/#i-get-errors-from-the-no-undef-rule-about-global-variables-not-being-defined-even-though-there-are-no-typescript-errors
"no-undef": "off",
"no-debugger": "warn",
"no-param-reassign": ["error", { props: false }],
"no-bitwise": "off",
Expand Down
Loading