Replace Rustybuzz with Parley for text layout, and add text tilt parameter #2739
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BKSalman
force-pushed
the
parley
branch
3 times, most recently
from
e836f23 to
49d81c8
Compare
Keavon
changed the title
BKSalman
force-pushed
the
parley
branch
4 times, most recently
from
cd5aff5 to
5b5373a
Compare
|
!build |
|
|
!build |
|
|
!build |
|
|
!build |
|
BKSalman
force-pushed
the
parley
branch
3 times, most recently
from
b999cf6 to
50b2e6b
Compare
|
!build |
|
BKSalman
force-pushed
the
parley
branch
2 times, most recently
from
1eb89d9 to
2bc822b
Compare
|
!build |
|
change text input direction based on text direction
this also adds migration code for documents that don't have shear
- add shear property - set character spacing to 0
Keavon
changed the title
Keavon
changed the title
Keavon
approved these changes
Jul 1, 2025
15 tasks
Closed
urisinger
pushed a commit
to urisinger/Graphite
that referenced
this pull request
Jul 15, 2025
…meter (GraphiteEditor#2739) * replace rustybuzz with parley for text layout handling change text input direction based on text direction * Code review * change default character spacing to 0 * add shear to text node this also adds migration code for documents that don't have shear * shear migration for text node - add shear property - set character spacing to 0 * use old max_width and max_height in text migration if available * Final code review pass * Add units to the parameters --------- Co-authored-by: Keavon Chambers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1105. Closes #2707.
this adds Parley which handles a lot of text related stuff for us
I made this PR to get feedback on the changes
and after this is accepted, some of the listed TODOs from this issue can be resolved easily, which I could either add to this PR, or make another PR for them
I've created this simple file that I tested with, you can also use it (you need to use a font that supports Arabic, something like
Tajawal)it should look like this
TODOs: