Instance tables refactor part 8: Output the type of the input data with the Mirror node as well #2699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keavon
changed the title
Keavon
changed the title
9 tasks
Keavon
force-pushed
the
flatten-mirror-output
branch
from
7c2a0c2 to
6862e1f
Compare
Keavon
approved these changes
Jun 7, 2025
seam0s-dev
pushed a commit
to seam0s-dev/Graphite
that referenced
this pull request
Jun 8, 2025
…th the Mirror node as well (GraphiteEditor#2699) * Flatten output of mirror node * Enable reflection based on pivot, not just bounds --------- Co-authored-by: Keavon Chambers <[email protected]>
mTvare6
pushed a commit
that referenced
this pull request
Jun 8, 2025
…th the Mirror node as well (#2699) * Flatten output of mirror node * Enable reflection based on pivot, not just bounds --------- Co-authored-by: Keavon Chambers <[email protected]>
Keavon
added a commit
that referenced
this pull request
Jun 20, 2025
…th the Mirror node as well (#2699) * Flatten output of mirror node * Enable reflection based on pivot, not just bounds --------- Co-authored-by: Keavon Chambers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partly closes #1834.
The mirror node now outputs
Instances<VectorData>when inputInstances<VectorData>. Previously it outputInstances<GraphicElement>The advantage being of course that the colour is slightly different:
