Replace Runtime package with Mirror #82
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulofaria
approved these changes
May 13, 2021
|
Thank you @adam-fowler! |
|
Shall I merge this and the flatten PR? |
|
@adam-fowler Please do! Feel free to also create the tags. 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Runtimelibrary has loads of errors when you run it with the address sanitizer and crashes the thread sanitizer on Linux. Given the GraphQL package is most likely going to be used in a multi-threaded environment not having the thread sanitizer is a real concern.It appears all the requirements from
Runtimecan be satisfied withMirrorso I replaced it. I might have missed something but all the tests pass.