Adds GraphQLError extensions #128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These can be removed because the other cases are there to support standard non-Map scalars. Since OrderedDictionary is already covered by Map.dictionary, we don't ever enter these cases.
NeedleInAJayStack
force-pushed
the
feature/error-extensions
branch
from
5079572 to
9aded4c
Compare
Closed
NeedleInAJayStack
force-pushed
the
feature/error-extensions
branch
from
2f6e190 to
88ba89f
Compare
Drops code climate integration
NeedleInAJayStack
force-pushed
the
feature/error-extensions
branch
from
88ba89f to
aed9770
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an extensions property to
GraphQLError, resolving #127It also makes other minor fixes, including changing expectation waits to avoid warnings and removing unused encoder cases that also produced warnings.
Due to formatting changes, it is probably easiest to review commit-by-commit.
This is a backwards-compatible minor change.