dynamic dashboard path #1337
Closed
dynamic dashboard path #1337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cd `dirname $0`/app/dashboard VITE_BASE_API=/api/ npm run build --if-present -- --outDir build --assetsDir statics cp ./build/index.html ./build/404.html
Contributor
Author
|
Before merging, it's necessary to change the workflow for building the container, specifically the section: - name: Build project
working-directory: ./app/dashboard
run: VITE_BASE_API=/api/ npm run build --if-present -- --outDir build --base '/dashboard/'Change it to: - name: Build project
working-directory: ./app/dashboard
run: VITE_BASE_API=/api/ npm run build --if-present -- --outDir build --assetsDir statics |
Contributor
|
It need to rebuild after chang path? |
Contributor
|
Please change the target branch to dev |
Contributor
Author
no, only restart |
Contributor
|
change the target branch to dev |
Contributor
Author
|
If a merge into the dev branch is required, I will rebuild the frontend and reopen the PR since the versions differ. |
Contributor
|
Yes we need to test it first |
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DASHBOARD_PATH = "/dashboard/"
in .env