Fix https://github.com/GoogleContainerTools/rules_distroless/issues/170 #171
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @gfrankliu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses a critical bug in a build script within the rules_distroless repository. The change ensures that a shell script executes from the correct directory context (the Bazel workspace root) rather than a potentially incorrect build working directory. This fix is crucial for the script to correctly resolve paths and perform its intended operations, such as writing lockfiles, thereby resolving a reported issue.
Highlights
- Build Script Directory Fix: Corrected the working directory for the
copy.sh.tmplscript fromBUILD_WORKING_DIRECTORYtoBUILD_WORKSPACE_DIRECTORY. This ensures that the script operates from the root of the Bazel workspace, resolving issues related to incorrect path resolution, as reported in issue #170.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request fixes an issue where bazel run @...//:lock would fail because it was using BUILD_WORKING_DIRECTORY, which is not set in the bazel run environment. The change correctly switches to BUILD_WORKSPACE_DIRECTORY, which is the correct variable for this context. The fix is appropriate and addresses the reported issue. I've added one suggestion to make the script more robust by explicitly checking for the presence of the BUILD_WORKSPACE_DIRECTORY variable and providing a more user-friendly error message if it's missing.
Fix #170