Skip to content

Conversation

vs-odie
Copy link

@vs-odie vs-odie commented May 30, 2025

This PR introduces a design document proposing support for kpt Apply-Time-Mutation (ATM) in the Config Sync remediator. Currently, only the applier honors ATM annotations, which can lead to resources being reverted to their unmutated state by the remediator. The proposed change ensures that ATM substitutions are applied consistently during both initial apply and ongoing reconciliation, improving correctness and user experience. The design also references real-world needs for cross-resource value injection, as highlighted in k8s-config-connector Issue #101

Copy link

google-cla bot commented May 30, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mikebz for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot requested a review from mikebz May 30, 2025 08:18
@google-oss-prow google-oss-prow bot requested a review from sdowell May 30, 2025 08:18
Copy link

Hi @vs-odie. Thanks for your PR.

I'm waiting for a GoogleContainerTools member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mikebz
Copy link
Contributor

mikebz commented May 30, 2025

thank you for contributing a well thought out proposal and following the design doc pattern! Adding to me review list. Apply time mutations have been a subject of much debate over the years.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants