Skip to content
This repository was archived by the owner on Jun 3, 2025. It is now read-only.

Fix home and group set for user command#995

Merged
tejal29 merged 1 commit intoGoogleContainerTools:masterfrom
tejal29:507
Jan 25, 2020
Merged

Fix home and group set for user command#995
tejal29 merged 1 commit intoGoogleContainerTools:masterfrom
tejal29:507

Conversation

@tejal29
Copy link
Copy Markdown
Contributor

@tejal29 tejal29 commented Jan 23, 2020

Fixes #507

Description
In this PR,

  • If group string is not specified in USER command, it is set to user.
  • Move addDefaultHOME call after config.User is parsed and group is separated.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

Release Notes

Describe any changes here so maintainer can include it in the release notes, or delete this block.

GID now defaults to UID if not set for USER command
HOME is set correctly when group string present in USER command e.g. `USER user:grp` 

@googlebot googlebot added the cla: yes CLA signed by all commit authors label Jan 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

candidate-release cla: yes CLA signed by all commit authors

Projects

None yet

Development

Successfully merging this pull request may close these issues.

USER command set wrong $HOME or gid

3 participants