Skip to content
This repository was archived by the owner on Jun 3, 2025. It is now read-only.

Prefer platform that is currently running for pulling remote images and kaniko binary Makefile target#980

Merged
tejal29 merged 2 commits intoGoogleContainerTools:masterfrom
PhoenixMage:PR646_rebase_fix
Jan 22, 2020
Merged

Prefer platform that is currently running for pulling remote images and kaniko binary Makefile target#980
tejal29 merged 2 commits intoGoogleContainerTools:masterfrom
PhoenixMage:PR646_rebase_fix

Conversation

@PhoenixMage
Copy link
Copy Markdown
Contributor

Fixes #646 rebase.

I needed this for my arm64 k8s cluster. I have zero Go experience but
enough experience with other things to fix the rebase (I think!). This
patch is working fine on my cluster.

I needed this for my arm64 k8s cluster. I have zero Go experience but
enough experience with other things to fix the rebase (I think!). This
patch is working fine on my cluster.
@googlebot
Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no CLA not signed by all commit authors label Jan 20, 2020
@PhoenixMage
Copy link
Copy Markdown
Contributor Author

@googlebot I signed it!

@googlebot
Copy link
Copy Markdown

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes CLA signed by all commit authors and removed cla: no CLA not signed by all commit authors labels Jan 20, 2020
@tejal29
Copy link
Copy Markdown
Contributor

tejal29 commented Jan 21, 2020

Thanks @PhoenixMage since you had to rebase this multiple times last time you raised this PR, i really want to get this in sooner :)
I fixed the lint error and ran integration tests.

@tejal29 tejal29 changed the title Rebase fix for PR #646 Prefer platform that is currently running for pulling remote images and kaniko binary Makefile target Jan 22, 2020
@tejal29 tejal29 merged commit 6a6c547 into GoogleContainerTools:master Jan 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes CLA signed by all commit authors

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants