Skip to content
This repository was archived by the owner on Jun 3, 2025. It is now read-only.

Only build required docker images for integration tests#898

Merged
tejal29 merged 2 commits intoGoogleContainerTools:masterfrom
cvgw:u/cvgw/improve-integration-test-runner
Dec 13, 2019
Merged

Only build required docker images for integration tests#898
tejal29 merged 2 commits intoGoogleContainerTools:masterfrom
cvgw:u/cvgw/improve-integration-test-runner

Conversation

@cvgw
Copy link
Copy Markdown
Contributor

@cvgw cvgw commented Dec 2, 2019

Fixes #897
Description

Only build docker images for the integration tests that actually run rather than for all integration tests regardless of which will run.

This will greatly reduce the time it takes to run an individual integration test.

Looking at the kokoro history, this change doesn't seem to impact performance when running the entire test suite.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Adds integration tests if needed.

See the contribution guide for more details.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

Release Notes

- Only build docker images for the integration tests being run

@cvgw cvgw force-pushed the u/cvgw/improve-integration-test-runner branch from fbda4c0 to addf04f Compare December 2, 2019 20:01
@cvgw cvgw changed the title Work in progress Only build required docker images for integration tests Dec 2, 2019
@cvgw cvgw force-pushed the u/cvgw/improve-integration-test-runner branch from addf04f to 14542a0 Compare December 2, 2019 21:03
Only build the docker images required for the integration tests which
will be executed rather than building all docker images every time.
@cvgw cvgw force-pushed the u/cvgw/improve-integration-test-runner branch from 14542a0 to c2645b2 Compare December 2, 2019 21:19
@cvgw cvgw requested review from priyawadhwa and tejal29 December 2, 2019 21:35
Comment thread integration/integration_test.go Outdated
@cvgw cvgw requested a review from tejal29 December 9, 2019 21:58
@tejal29 tejal29 merged commit 14e1449 into GoogleContainerTools:master Dec 13, 2019
@cvgw cvgw deleted the u/cvgw/improve-integration-test-runner branch December 13, 2019 21:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Integration suite should build images only for tests that will actually be run

2 participants