This repository was archived by the owner on Jun 3, 2025. It is now read-only.
Fix quote strip behavior for ARG values#850
Merged
tejal29 merged 1 commit intoGoogleContainerTools:masterfrom Nov 14, 2019
Merged
Fix quote strip behavior for ARG values#850tejal29 merged 1 commit intoGoogleContainerTools:masterfrom
tejal29 merged 1 commit intoGoogleContainerTools:masterfrom
Conversation
* fixes issue 847 * previous implementation did not properly parse blank values which were enclosed in quotes
cvgw
force-pushed
the
u/cgwippern/847_empty_arg_bug
branch
from
c5f9ea5 to
006b499
Compare
tejal29
approved these changes
Nov 14, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #847
Description
previous implementation did not properly parse blank values which were enclosed in quotes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Reviewer Notes
Release Notes
No user facing changes
Adds a new integration test case