This repository was archived by the owner on Jun 3, 2025. It is now read-only.
fix build_args in MakeFile, have Travis run make images to preven issue in future#821
Merged
tejal29 merged 4 commits intoGoogleContainerTools:masterfrom Oct 18, 2019
Merged
Conversation
tejal29
added
area/internal
tejal29
approved these changes
Oct 18, 2019
Contributor
|
Thanks @slmagus for the quick PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #820. in case of a bug fix, this should point to a bug and any other related issue(s)
Description
Set new BUILD_ARGs value to null.
Configure Travis to run make images to test if the images can be built.
make images still fails on master, however it isn't failing on BUILD_ARGS anymore at least.EDIT: Build now passes after updating bazel-bin directory
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Reviewer Notes
Release Notes
simple bug fix. Adds more through testing to Travis to improve quality.