Skip to content
This repository was archived by the owner on Jun 3, 2025. It is now read-only.

fix unpacking archives via ADD#717

Merged
priyawadhwa merged 1 commit intoGoogleContainerTools:masterfrom
vm86:fix
Aug 19, 2019
Merged

fix unpacking archives via ADD#717
priyawadhwa merged 1 commit intoGoogleContainerTools:masterfrom
vm86:fix

Conversation

@vm86
Copy link
Copy Markdown
Contributor

@vm86 vm86 commented Jul 19, 2019

Bugfix: unpacking archives with ADD cos it recieves only a full destination path and ignores WORKDIR's directions.

Dockerfile example:

FROM busybox

WORKDIR /app

ADD test_file.tar .
RUN ls /app

@googlebot
Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@vm86
Copy link
Copy Markdown
Contributor Author

vm86 commented Jul 19, 2019

I signed it!

@googlebot
Copy link
Copy Markdown

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@vm86
Copy link
Copy Markdown
Contributor Author

vm86 commented Aug 18, 2019

Copy link
Copy Markdown
Contributor

@priyawadhwa priyawadhwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this!

@priyawadhwa priyawadhwa merged commit 0694be3 into GoogleContainerTools:master Aug 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants