Skip to content
This repository was archived by the owner on Jun 3, 2025. It is now read-only.

Add support for S3 custom endpoint#698

Merged
priyawadhwa merged 1 commit intoGoogleContainerTools:masterfrom
takmatsu:s3-endpoint
Sep 13, 2019
Merged

Add support for S3 custom endpoint#698
priyawadhwa merged 1 commit intoGoogleContainerTools:masterfrom
takmatsu:s3-endpoint

Conversation

@takmatsu
Copy link
Copy Markdown
Contributor

For S3-compatible object storage (like minio),
this patch enable to use custom endpoint-url.

Fix #531

Usage:

apiVersion: v1
kind: Pod
metadata:
  name: kaniko
spec:
  containers:
  - name: kaniko
    image: REGISTRY/PROJECT/REPOSITORY:TAG
    args: ["--dockerfile=Dockerfile",
            "--context=s3://BUCKET/FILE",
            "--destination=REGISTRY/PROJECT/REPOSITORY:TAG"]
    env:
      - name: AWS_ACCESS_KEY_ID
        value: MINIO_ACCESS_KEY
      - name: AWS_SECRET_ACCESS_KEY
        value: MINIO_SECRET_KEY
      - name: AWS_REGION
        value: us-east-1
      - name: S3_ENDPOINT
        value: http://minio-server:9000
      - name: S3_FORCE_PATH_STYLE
        value: "true"
    volumeMounts:
      - name: docker-config
        mountPath: /kaniko/.docker/
  restartPolicy: Never
  volumes:
    - name: docker-config
      configMap:
        name: docker-config

For S3-compatible object storage (like minio),
this patch enable to use custom endpoint-url.

Fix GoogleContainerTools#531
@pennycoders
Copy link
Copy Markdown

Hi,

Is this PR going to be merged any time soon ?

Thanks,

Alex.

@takmatsu
Copy link
Copy Markdown
Contributor Author

cc/ @priyawadhwa

@hegand
Copy link
Copy Markdown

hegand commented Aug 27, 2019

+1

Copy link
Copy Markdown
Contributor

@priyawadhwa priyawadhwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this -- I'm not super familiar with S3 and I don't know that it's possible to add an integration test for this. Have you tested locally?

@takmatsu
Copy link
Copy Markdown
Contributor Author

Sure, I have tested locally for both S3 and Custom endpoint(minio).
I think we can add integration tests as a code, but it needs some environments...

@priyawadhwa
Copy link
Copy Markdown
Contributor

Yah so we don't have the setup to test with S3 -- but if it's working locally I think we can go ahead and add this change.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for private object storage (minio)

5 participants