This repository was archived by the owner on Jun 3, 2025. It is now read-only.
Add support for S3 custom endpoint#698
Merged
priyawadhwa merged 1 commit intoGoogleContainerTools:masterfrom Sep 13, 2019
Merged
Add support for S3 custom endpoint#698priyawadhwa merged 1 commit intoGoogleContainerTools:masterfrom
priyawadhwa merged 1 commit intoGoogleContainerTools:masterfrom
Conversation
For S3-compatible object storage (like minio), this patch enable to use custom endpoint-url. Fix GoogleContainerTools#531
|
Hi, Is this PR going to be merged any time soon ? Thanks, Alex. |
Contributor
Author
|
cc/ @priyawadhwa |
|
+1 |
priyawadhwa
approved these changes
Sep 9, 2019
Contributor
priyawadhwa
left a comment
There was a problem hiding this comment.
Thanks for adding this -- I'm not super familiar with S3 and I don't know that it's possible to add an integration test for this. Have you tested locally?
Contributor
Author
|
Sure, I have tested locally for both S3 and Custom endpoint(minio). |
Contributor
|
Yah so we don't have the setup to test with S3 -- but if it's working locally I think we can go ahead and add this change. |
This was referenced Feb 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For S3-compatible object storage (like minio),
this patch enable to use custom endpoint-url.
Fix #531
Usage: