Skip to content
This repository was archived by the owner on Jun 3, 2025. It is now read-only.

Preserve options when doing a cache push#423

Merged
dlorenc merged 2 commits intoGoogleContainerTools:masterfrom
carlossg:insecure-cache
Nov 6, 2018
Merged

Preserve options when doing a cache push#423
dlorenc merged 2 commits intoGoogleContainerTools:masterfrom
carlossg:insecure-cache

Conversation

@carlossg
Copy link
Copy Markdown
Contributor

Otherwise options like insecure are lost

Otherwise options like `insecure` are lost
@container-tools-bot
Copy link
Copy Markdown
Collaborator

Hi @carlossg. Thanks for your PR.

I'm waiting for a GoogleContainerTools member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@carlossg
Copy link
Copy Markdown
Contributor Author

For the record this moves forward allowing insecure locally deployed docker registries but doesn't make it work yet, the builds still can't find the cached image even though it is in the repo

Comment thread pkg/executor/push.go
@dlorenc dlorenc merged commit 5ed45ed into GoogleContainerTools:master Nov 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants