Skip to content
This repository was archived by the owner on Jun 3, 2025. It is now read-only.

adding exit 1 when there are not enough command line vars passed to `…#415

Merged
priyawadhwa merged 1 commit intoGoogleContainerTools:masterfrom
j0shua:master
Oct 26, 2018
Merged

adding exit 1 when there are not enough command line vars passed to `…#415
priyawadhwa merged 1 commit intoGoogleContainerTools:masterfrom
j0shua:master

Conversation

@j0shua
Copy link
Copy Markdown
Contributor

@j0shua j0shua commented Oct 26, 2018

…run in docker` script

@googlebot
Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@container-tools-bot
Copy link
Copy Markdown
Collaborator

Hi @j0shua. Thanks for your PR.

I'm waiting for a GoogleContainerTools member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@j0shua
Copy link
Copy Markdown
Contributor Author

j0shua commented Oct 26, 2018

I signed it!

@googlebot
Copy link
Copy Markdown

CLAs look good, thanks!

Copy link
Copy Markdown
Contributor

@priyawadhwa priyawadhwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@priyawadhwa priyawadhwa merged commit 1996bf8 into GoogleContainerTools:master Oct 26, 2018
@j0shua
Copy link
Copy Markdown
Contributor Author

j0shua commented Oct 26, 2018

thanks @priyawadhwa !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants