This repository was archived by the owner on Jun 3, 2025. It is now read-only.
Replace gometalinter with GolangCI-Lint#349
Merged
priyawadhwa merged 3 commits intoGoogleContainerTools:masterfrom Sep 11, 2018
Merged
Replace gometalinter with GolangCI-Lint#349priyawadhwa merged 3 commits intoGoogleContainerTools:masterfrom
priyawadhwa merged 3 commits intoGoogleContainerTools:masterfrom
Conversation
gometalinter is broken @ HEAD, and I looked into why that was. During that process, I remembered that we took the linting scripts from skaffold, and found that in skaffold gometalinter was replaced with GolangCI-Lint: GoogleContainerTools/skaffold#619 The change made linting in skaffold faster, so I figured instead of fixing gometalinter it made more sense to remove it and replace it with GolangCI-Lint for kaniko as well.
priyawadhwa
force-pushed
the
gometalinter
branch
2 times, most recently
from
0312c0e to
c711632
Compare
priyawadhwa
force-pushed
the
gometalinter
branch
from
c711632 to
ccb6259
Compare
tstromberg
approved these changes
Sep 11, 2018
|
|
||
| func checkLayers(t *testing.T, image1, image2 string, offset int) error { | ||
| func checkLayers(t *testing.T, image1, image2 string, offset int) { | ||
| img1, err := getImageDetails(image1) |
There was a problem hiding this comment.
I'm not a big fan of custom assert methods, but this should at least call t.Helper().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gometalinter is broken @ HEAD, and I looked into why that was. During
that process, I remembered that we took the linting scripts from
skaffold, and found that in skaffold gometalinter was replaced with
GolangCI-Lint:
GoogleContainerTools/skaffold#619
The change made linting in skaffold faster, so I figured instead of
fixing gometalinter it made more sense to remove it and replace it with
GolangCI-Lint for kaniko as well.