This repository was archived by the owner on Jun 3, 2025. It is now read-only.
Make sure paths are absolute before matching files to wildcard sources#330
Merged
priyawadhwa merged 1 commit intoGoogleContainerTools:masterfrom Aug 31, 2018
Merged
Conversation
The bug in GoogleContainerTools#329 occurred because of a bug in matchSources, where the filepath wasn't absolute, so the source "/kaniko-bug/*" wasn't being matched to the file "kaniko-bug/test-file" To fix this, I added logic for making filepaths absolute and added to the unit test for the function to test that it works.
aaron-prindle
approved these changes
Aug 31, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug in #329 occurred because of a bug in matchSources, where the
filepath wasn't absolute, so the source "/kaniko-bug/*" wasn't being
matched to the file "kaniko-bug/test-file"
To fix this, I added logic for making filepaths absolute and added to
the unit test for the function to test that it works.