This repository was archived by the owner on Jun 3, 2025. It is now read-only.
Enable pushing cache with --no-push#3181
Merged
aaron-prindle merged 1 commit intoGoogleContainerTools:mainfrom Jun 4, 2024
Merged
Enable pushing cache with --no-push#3181aaron-prindle merged 1 commit intoGoogleContainerTools:mainfrom
aaron-prindle merged 1 commit intoGoogleContainerTools:mainfrom
Conversation
Make sure we check --no-cache-push instead of --no-push when deciding whether to push cache or not.
aaron-prindle
approved these changes
Jun 4, 2024
Collaborator
aaron-prindle
left a comment
aaron-prindle
left a comment
There was a problem hiding this comment.
Thanks @leosunmo for the fix and explanation here. LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure we check --no-cache-push instead of --no-push when deciding whether to push cache or not.
Fixes #3180
Description
Allows for pushing to cache even if
--no-pushis enabled. This is useful in scenarios where you want to benefit (and contribute) to cache but ultimately save the image to a tar file, for example when container scanning in CI pipelines.Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
Reviewer Notes
Release Notes
Enable pushing cache even when
--no-pushis provided. To disable pushing cache, use--no-push-cache.