This repository was archived by the owner on Jun 3, 2025. It is now read-only.
warmer validate and copy registry mirror to registry map#3140
Merged
aaron-prindle merged 1 commit intoGoogleContainerTools:mainfrom May 14, 2024
Merged
Conversation
aaron-prindle
approved these changes
May 14, 2024
Collaborator
aaron-prindle
left a comment
aaron-prindle
left a comment
There was a problem hiding this comment.
LGTM, thanks for the PR here @prima101112!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3134
Description
seems like warmer is not updated when 1.21 is updated registry mirror mapped to registry map
and warmer are also using remote package
here
1bf529e
warmer is not touch and some users actually use warmer and using --registry-mirror flag
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
Reviewer Notes
Release Notes
warmer will have same behaviour when using --registry-mirror also add --registry-map to warmer