This repository was archived by the owner on Jun 3, 2025. It is now read-only.
Fix COPY fails when multiple files are copied to path specified in ENV#3034
Merged
aaron-prindle merged 4 commits intoGoogleContainerTools:mainfrom Mar 19, 2024
Merged
Conversation
aaron-prindle
approved these changes
Mar 19, 2024
Collaborator
aaron-prindle
left a comment
There was a problem hiding this comment.
LGTM, thanks for the fix here @Greendor1234!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2946
Description
The problem is that the value inside the variable
sd.DestPathis not updated with the value returned from the functionResolveEnvironmentReplacementList, so when the functionIsSrcsValidis called to validate the destination there is still the environment variable unsolved.So I added a line that updates the
sd.DestPathwith the value returned from the functionResolveEnvironmentReplacementListSubmitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Reviewer Notes