Skip to content
This repository was archived by the owner on Jun 3, 2025. It is now read-only.

fix: also update github.com/awslabs/amazon-ecr-credential-helper to resolve issues with AWS ECR authentication (resolves #2882)#2908

Merged
aaron-prindle merged 1 commit intoGoogleContainerTools:mainfrom
pdecat:fix/aws_ecr
Dec 15, 2023

Conversation

@pdecat
Copy link
Copy Markdown
Contributor

@pdecat pdecat commented Dec 15, 2023

Resolves #2882.

This is basically:

# git checkout main
# go get -u github.com/awslabs/amazon-ecr-credential-helper/...
# go mod tidy
# go mod vendor
# git add -A

Signed-off-by: Patrick Decat pdecat@gmail.com

…esolve issues with AWS ECR authentication

As mentioned in aws/aws-sdk-go-v2#2370, AWS
SDK for Go v2 releases after 2023/11/15 broke compatibility with all
previous releases.

Resolves GoogleContainerTools#2882

Signed-off-by: Patrick Decat <pdecat@gmail.com>
@aaron-prindle
Copy link
Copy Markdown
Collaborator

Thank you @pdecat for the fix PR here! Going to validate the fix with other folks in the #2882 thread before closing and then we should be able to release a new patch version Kaniko that is stable for AWS ECR users 🎊

@aaron-prindle aaron-prindle merged commit a946b82 into GoogleContainerTools:main Dec 15, 2023
@pdecat pdecat deleted the fix/aws_ecr branch January 16, 2024 13:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AWS ECR build permissions issue with Kaniko v1.19.0 & v1.19.1 (found using v1.19.0-debug & v1.19.1-debug)

2 participants