This repository was archived by the owner on Jun 3, 2025. It is now read-only.
Ensure cmd.SysProcAttr is set before modifying it#275
Merged
priyawadhwa merged 1 commit intoGoogleContainerTools:masterfrom Aug 7, 2018
Merged
Ensure cmd.SysProcAttr is set before modifying it#275priyawadhwa merged 1 commit intoGoogleContainerTools:masterfrom
priyawadhwa merged 1 commit intoGoogleContainerTools:masterfrom
Conversation
priyawadhwa
approved these changes
Aug 7, 2018
Contributor
priyawadhwa
left a comment
priyawadhwa
left a comment
There was a problem hiding this comment.
Thanks for fixing this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A segfault was introduced by #271 because cmd.SysProcAttr can be referenced before it has been set in the case where config.User is not blank.
This caught me out while trying to use the gradle image which sets a user. I verified that the segfault no longer occurs after this change.