This repository was archived by the owner on Jun 3, 2025. It is now read-only.
Add guide on creating multi-arch manifests#2306
Merged
aaron-prindle merged 2 commits intoGoogleContainerTools:mainfrom Jun 7, 2023
Merged
Add guide on creating multi-arch manifests#2306aaron-prindle merged 2 commits intoGoogleContainerTools:mainfrom
aaron-prindle merged 2 commits intoGoogleContainerTools:mainfrom
Conversation
Collaborator
|
@Jasper-Ben thanks for the PR here! If you can rebase this, I'd be happy to review and get this in! |
|
@Jasper-Ben do you need help on this PR to rebased it? I have vested interest to enable kaniko multiarch build so i will like to help. |
Contributor
Author
|
@aaron-prindle @eugenejen |
Jasper-Ben
force-pushed
the
document_multiarch_manifest
branch
2 times, most recently
from
89564d4 to
9ffc009
Compare
While kaniko itself does not natively support building multi-arch container manifests, it may be used in combination with tools such as manifest-tool to create and merge seperate arch builds into a single manifest. Fixes GoogleContainerTools#1102 Fixes GoogleContainerTools#786
Jasper-Ben
force-pushed
the
document_multiarch_manifest
branch
from
9ffc009 to
5e7364c
Compare
Contributor
Author
|
Done. I also noticed a missing toc entry, which I fixed in separate commit b097cd2 Feel free to cherry-pick into separate PR, if you so prefer 🙂 |
eugenejen
reviewed
Jun 6, 2023
Contributor
Author
|
Good catch! Thats on me. Doctoc kept changing the document layout for me, so I changed this part manually. Will push a fix tomorrow.
|
Collaborator
|
Thanks for updating the PR here @Jasper-Ben! Once the last fix you mentioned is in we can merge 🎊 |
Jasper-Ben
force-pushed
the
document_multiarch_manifest
branch
from
b097cd2 to
06a6535
Compare
eugenejen
approved these changes
Jun 7, 2023
|
@aaron-prindle can you look at the PR? |
aaron-prindle
approved these changes
Jun 7, 2023
Collaborator
aaron-prindle
left a comment
aaron-prindle
left a comment
There was a problem hiding this comment.
LGTM! Thanks for this @Jasper-Ben!
kylecarbs
pushed a commit
to coder/kaniko
that referenced
this pull request
Jul 12, 2023
* Add guide on creating multi-arch manifests While kaniko itself does not natively support building multi-arch container manifests, it may be used in combination with tools such as manifest-tool to create and merge seperate arch builds into a single manifest. Fixes GoogleContainerTools#1102 Fixes GoogleContainerTools#786 * Add missing toc entry
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While kaniko itself does not natively support building multi-arch container manifests, it may be used in combination with tools such as manifest-tool to create and merge seperate arch builds into a single manifest.
Fixes #1102
Fixes #786
Description
While kaniko itself does not natively support building multi-arch container manifests, it may be used in combination with tools such as manifest-tool to create and merge seperate arch builds into a single manifest.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Reviewer Notes