update go-containerregistry so that kaniko works with Harbor#227
Conversation
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
55069c4 to
8a7e2a3
Compare
|
CLAs look good, thanks! |
|
Hey @everpeace, since this is a change to go-containerregistry, you'll have to submit this change in that repo first and then we can vendor in the changes. Edit: Whoops just realized that's exactly what you did (sorry, somehow I must have not fully read the PR description!) |
|
Thanks so much for contributing! |
|
@priyawadhwa Thanks for merging this! Would you mind me telling when I expected those images were updated after this PR being merged. But it seems not. |
Hi! Thanks for maintaining the great project!
Recently, I confirmed current version of kaniko doesn't work well with Harbor as I stated two issues below:
After my research, I understand the reason might be harbor's implementation. However, my workaround(google/go-containerregistry#219) was merged in go-containerregistry to make go-containerregistry more robust on various docker container registry implementations even when some implementations doesn't follow the docker registry specs. Also, another issue(google/go-containerregistry#220) reported that exactly the same error happens in gitlab.
So, I would like kaniko to pull the change so that kaniko works nicely with private docker registry implementations (at least with harbor, gitlab).