Skip to content
This repository was archived by the owner on Jun 3, 2025. It is now read-only.

Documentation: Clarify README.md blurb on --cache-copy-layers#2064

Merged
tejal29 merged 1 commit intoGoogleContainerTools:mainfrom
korenyoni:main
May 16, 2022
Merged

Documentation: Clarify README.md blurb on --cache-copy-layers#2064
tejal29 merged 1 commit intoGoogleContainerTools:mainfrom
korenyoni:main

Conversation

@korenyoni
Copy link
Copy Markdown
Contributor

@korenyoni korenyoni commented Apr 27, 2022

Relates to #1940

Description

This clarifies the blurb on --cache-copy-layers in README.md, which is misleading to readers and can imply that it controls layer caching for both RUN and COPY, but in fact only refers to COPY as the name of the flag suggests.

Related issues:

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Adds integration tests if needed.

See the contribution guide for more details.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

Release Notes

Describe any changes here so maintainer can include it in the release notes, or delete this block.

@google-cla
Copy link
Copy Markdown

google-cla Bot commented Apr 27, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

@tejal29 tejal29 merged commit ce1fb51 into GoogleContainerTools:main May 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants