This repository was archived by the owner on Jun 3, 2025. It is now read-only.
Use canonical platform values. Fix 1995.#2025
Merged
imjasonh merged 2 commits intoGoogleContainerTools:mainfrom Mar 31, 2022
Merged
Use canonical platform values. Fix 1995.#2025imjasonh merged 2 commits intoGoogleContainerTools:mainfrom
imjasonh merged 2 commits intoGoogleContainerTools:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). For more information, open the CLA check for this pull request. |
imjasonh
reviewed
Mar 31, 2022
Prior to this change, Kaniko was not using the platform's canonical value.
imjasonh
approved these changes
Mar 31, 2022
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1995
Description
Prior to this change, Kaniko was not using the platform's canonical value.
On this PR
Normalizefunction fromcontainerdmodule is used to get the canonical platform. To get the platform valueDefaultSpechas been replaced byDefaultSpec.Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
Reviewer Notes