Skip to content
This repository was archived by the owner on Jun 3, 2025. It is now read-only.

Remove k8schain, directly depend on cred helpers#1891

Merged
mattmoor merged 1 commit intomainfrom
no-k8schain
Jan 21, 2022
Merged

Remove k8schain, directly depend on cred helpers#1891
mattmoor merged 1 commit intomainfrom
no-k8schain

Conversation

@imjasonh
Copy link
Copy Markdown
Contributor

@imjasonh imjasonh commented Jan 21, 2022

This bumps to the latest k8schain dep, but then removes it entirely, instead preferring to replace NewNoClient with the equivalent cred helper wrappers without the (unused) keychain that used Kubernetes secrets.

Since these were unused, this should not be a functional change, and now we can drop the large k8s.io client dependencies. 🎉

Closes #1872

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Adds integration tests if needed.

See the contribution guide for more details.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

Release Notes

Describe any changes here so maintainer can include it in the release notes, or delete this block.

Remove cred helpers from images. Instead, we statically link the same cred helper logic into kaniko.

@imjasonh imjasonh requested a review from mattmoor January 21, 2022 17:03
@mattmoor
Copy link
Copy Markdown
Contributor

image

🤩

Comment thread deploy/Dockerfile Outdated
Comment thread deploy/Dockerfile
@mattmoor
Copy link
Copy Markdown
Contributor

Other than figuring out the release orchestration, this seems like a great change.

I see unit tests failing, and think we should discuss the release bits, but otherwise this LGTM.

@imjasonh imjasonh changed the title Remove k8schain, statically link helpers, remove them from Dockerfiles Remove k8schain, directly depend on cred helpers Jan 21, 2022
@imjasonh
Copy link
Copy Markdown
Contributor Author

image

🤩

Screen Shot 2022-01-21 at 2 16 25 PM

🤩🤩

@mattmoor mattmoor merged commit a7425d1 into main Jan 21, 2022
@mattmoor mattmoor deleted the no-k8schain branch January 21, 2022 20:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RFC: Statically link cred helpers, include them in slim image

2 participants