Skip to content
This repository was archived by the owner on Jun 3, 2025. It is now read-only.

Bump github.com/docker/docker to latest release#1866

Merged
imjasonh merged 2 commits intoGoogleContainerTools:mainfrom
imjasonh:bump-docker
Jan 14, 2022
Merged

Bump github.com/docker/docker to latest release#1866
imjasonh merged 2 commits intoGoogleContainerTools:mainfrom
imjasonh:bump-docker

Conversation

@imjasonh
Copy link
Copy Markdown
Contributor

@imjasonh imjasonh commented Dec 30, 2021

Description

go get -u github.com/docker/docker
go mod tidy
go mod vendor

...fix some build breakages...
...remove replace directives...
...add some new replace directives...
...fix some build breakages...
...fix some unit test breakages...

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Adds integration tests if needed.

See the contribution guide for more details.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

Release Notes

Describe any changes here so maintainer can include it in the release notes, or delete this block.

Update dependency on github.com/docker/docker to v20.10.12

@imjasonh
Copy link
Copy Markdown
Contributor Author

Please don't merge this until we have CI back in place, I'm not sure this passes.

@imjasonh imjasonh marked this pull request as draft January 14, 2022 18:28
fix build breakages
fix unit test
Trying to see whether am-i-in-a-container checks are broken for integration tests...
@imjasonh imjasonh marked this pull request as ready for review January 14, 2022 19:54
@imjasonh
Copy link
Copy Markdown
Contributor Author

@priyawadhwa this should be ready for a review now, integration tests pass (🎉!!) and I think the "Build images" checks would have failed by now if something was wrong.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants