This repository was archived by the owner on Jun 3, 2025. It is now read-only.
Bump github.com/docker/docker to latest release#1866
Merged
imjasonh merged 2 commits intoGoogleContainerTools:mainfrom Jan 14, 2022
Merged
Bump github.com/docker/docker to latest release#1866imjasonh merged 2 commits intoGoogleContainerTools:mainfrom
imjasonh merged 2 commits intoGoogleContainerTools:mainfrom
Conversation
89ef83c to
31c9b95
Compare
4 tasks
priyawadhwa
approved these changes
Jan 14, 2022
Contributor
Author
|
Please don't merge this until we have CI back in place, I'm not sure this passes. |
fix build breakages fix unit test Trying to see whether am-i-in-a-container checks are broken for integration tests...
Contributor
Author
|
@priyawadhwa this should be ready for a review now, integration tests pass (🎉!!) and I think the "Build images" checks would have failed by now if something was wrong. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
...fix some build breakages...
...remove
replacedirectives......add some new
replacedirectives......fix some build breakages...
...fix some unit test breakages...
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Reviewer Notes
Release Notes
Describe any changes here so maintainer can include it in the release notes, or delete this block.