Skip to content
This repository was archived by the owner on Jun 3, 2025. It is now read-only.

Revert "Support mirror registries with path component (#1707)"#1794

Merged
tejal29 merged 2 commits intoGoogleContainerTools:masterfrom
tejal29:revert_reg_fix
Oct 21, 2021
Merged

Revert "Support mirror registries with path component (#1707)"#1794
tejal29 merged 2 commits intoGoogleContainerTools:masterfrom
tejal29:revert_reg_fix

Conversation

@tejal29
Copy link
Copy Markdown
Contributor

@tejal29 tejal29 commented Oct 20, 2021

Fixes #1793 #1790 #1791

@tejal29 tejal29 merged commit ee31dc9 into GoogleContainerTools:master Oct 21, 2021
dancerj added a commit to dancerj/gitlstreefs that referenced this pull request Oct 31, 2021
This reverts commit 45c2dd5.

I believe the latest is now pointing back to 1.6 until the proper fix is landed.

GoogleContainerTools/kaniko#1791
GoogleContainerTools/kaniko#1794
bdwyertech added a commit to bdwyertech/kaniko-gitlab that referenced this pull request Nov 15, 2021
Pin to 1.6.0 until 1.7.1 fix is released

Ref: GoogleContainerTools/kaniko#1794
@stevemk14ebr
Copy link
Copy Markdown

stevemk14ebr commented Dec 16, 2021

Is there a fix for this planned? I expected to be able to take an existing dockerfile such as:

FROM golang:1.17-alpine

And instruct kaniko to use my mirror like this (fake domain names here for the example):

--registry-mirror harbor-ci.internal.io/team-images/library

Which would then pull from this final URL as if it was my FROM line:

harbor-ci.internal.io/team-images/library/golang:1.17-alpine

however, in reality this fails with the error:

error building image: registries must be valid RFC 3986 URI authorities:

I believe this occurs because of the URI /team-images/library/, but that is required to be passed keep dockerfiles independent from the build environment they're executed in, while pulling from the correct place on the mirror.

if it's unreasonable to fix --registry-mirror, then perhaps a new commandline option. Maybe --mirror-prefix or something.

@sanmai-NL
Copy link
Copy Markdown

@briandealwis What's your response to @stevemk14ebr?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes CLA signed by all commit authors

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Facing an issue while pushing the docker image to gcr. This was success few hours back

4 participants