This repository was archived by the owner on Jun 3, 2025. It is now read-only.
Specifying a tarPath will push the image as well#1597
Merged
tejal29 merged 1 commit intoGoogleContainerTools:masterfrom Mar 31, 2021
Merged
Specifying a tarPath will push the image as well#1597tejal29 merged 1 commit intoGoogleContainerTools:masterfrom
tejal29 merged 1 commit intoGoogleContainerTools:masterfrom
Conversation
* Specifying a tarPath will push the image as well
|
Could we get this merged ASAP? |
tejal29
approved these changes
Mar 31, 2021
|
hey, this has been merged but is there any plan to make a release? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1544
Description
The README specifies that adding
--tarPathwill create a tarball but also push the image to the registry.In my opinion this behaviour would be expected since the
--no-pushoption exists.I updated the
push.gofile so that it will only check for errors returned by the tarball generation instead of returning from there.Unfortunately there is no unit test for the tarball generation (that I could find), and I did not feel comfortable enough with the code to add one myself.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Reviewer Notes
Release Notes
Describe any changes here so maintainer can include it in the release notes, or delete this block.