Skip to content
This repository was archived by the owner on Jun 3, 2025. It is now read-only.

Use up-to-date ca-certificates during build#1580

Merged
tejal29 merged 1 commit intoGoogleContainerTools:masterfrom
SaschaSchwarze0:sascha-ca-certificates
Feb 23, 2021
Merged

Use up-to-date ca-certificates during build#1580
tejal29 merged 1 commit intoGoogleContainerTools:masterfrom
SaschaSchwarze0:sascha-ca-certificates

Conversation

@SaschaSchwarze0
Copy link
Copy Markdown
Contributor

Description

Kaniko used to have a committed ca-certificates.crt file that it puts into the Kaniko image. The file is three years old. That's not a viable approach from a functional perspective (it misses new root certificates that eventually get used to sign certificates used by a container registry), also not from a security perspective (because revoked certificates do not get removed).

I am changing the Dockerfiles to build that file.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Adds integration tests if needed.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

@google-cla google-cla Bot added the cla: yes CLA signed by all commit authors label Feb 15, 2021
@tejal29 tejal29 merged commit 2d4db8e into GoogleContainerTools:master Feb 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes CLA signed by all commit authors

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants