This repository was archived by the owner on Jun 3, 2025. It is now read-only.
doc: clarify the format of --registry-mirror#1504
Merged
tejal29 merged 1 commit intoGoogleContainerTools:masterfrom Dec 9, 2020
Merged
doc: clarify the format of --registry-mirror#1504tejal29 merged 1 commit intoGoogleContainerTools:masterfrom
tejal29 merged 1 commit intoGoogleContainerTools:masterfrom
Conversation
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
In the context of Docker Hub ratelimit, registry mirror has been applied more and more. It's very unfortunate that kaniko doesn't take the same form as docker/containerd. The registry mirror shouldn't have scheme like `https://` included. This is not explicitly described in the doc.
zhouhaibing089
force-pushed
the
registry-mirror
branch
from
31c9934 to
f6fb8cd
Compare
google-cla
Bot
added
cla: yes
tejal29
approved these changes
Dec 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In the context of Docker Hub ratelimit, registry mirror has been applied
more and more. It's very unfortunate that kaniko doesn't take the same
form as docker/containerd does. The registry mirror shouldn't have scheme
like
https://included. This is not explicitly described in the doc.Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Reviewer Notes
Release Notes
None.