This repository was archived by the owner on Jun 3, 2025. It is now read-only.
feat(warmer): Warmer now supports all registry-related flags#1499
Merged
tejal29 merged 1 commit intoGoogleContainerTools:masterfrom Dec 11, 2020
Merged
feat(warmer): Warmer now supports all registry-related flags#1499tejal29 merged 1 commit intoGoogleContainerTools:masterfrom
tejal29 merged 1 commit intoGoogleContainerTools:masterfrom
Conversation
Contributor
|
@vbehar Would be able to rebase this PR on master? |
Contributor
Author
|
sure, I'll do it today |
which means we can now: - set up one or more mirrors - set up registries certificates - skip TLS verify - use plain HTTP using the same set of flags that are defined for the executor
vbehar
force-pushed
the
warmer-registry-opts
branch
from
6a37fe5 to
ac2c71c
Compare
Contributor
Author
|
@tejal29 ok, rebased and ready |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1423
Description
This PR adds all registry-related flags to the
warmercommandwhich means we can now:
using the same set of flags that are defined for the
executorcommandSubmitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Reviewer Notes
Release Notes