Skip to content
This repository was archived by the owner on Jun 3, 2025. It is now read-only.

Fix permissions on cache when --no-push is set#1445

Merged
tejal29 merged 1 commit intoGoogleContainerTools:masterfrom
ejose19:ej/gcr-cache-nopush-fix
Oct 2, 2020
Merged

Fix permissions on cache when --no-push is set#1445
tejal29 merged 1 commit intoGoogleContainerTools:masterfrom
ejose19:ej/gcr-cache-nopush-fix

Conversation

@ejose19
Copy link
Copy Markdown
Contributor

@ejose19 ejose19 commented Oct 2, 2020

Fixes #1265

Description

Since pre-configuration of gcr credential helper was removed on v0.20.0, when using --no-push along with --cache, the credentials were never configured for the cache repo hence making both retrieving and pushing layers fails.

Proposing solution is: If --no-push is set, instead of not checking push permissions, we check if the --cache-repo has permissions.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Adds integration tests if needed.

See the contribution guide for more details.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

Release Notes

Describe any changes here so maintainer can include it in the release notes, or delete this block.

Examples of user facing changes:
- fix permissions on cache when using --no-push flag

@googlebot
Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no CLA not signed by all commit authors label Oct 2, 2020
@ejose19
Copy link
Copy Markdown
Contributor Author

ejose19 commented Oct 2, 2020

@googlebot I signed it!

@googlebot
Copy link
Copy Markdown

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes CLA signed by all commit authors and removed cla: no CLA not signed by all commit authors labels Oct 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes CLA signed by all commit authors

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GCR auth broken when --no-push is set since v0.20.0

3 participants