This repository was archived by the owner on Jun 3, 2025. It is now read-only.
new implementation for run#1383
Merged
tejal29 merged 1 commit intoGoogleContainerTools:masterfrom Aug 13, 2020
Merged
Conversation
tejal29
added
the
area/performance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
shd fix #1317 and #1316 Improve correctness for newly added "--use-new-run` flag
in this PR, instead of rely on file marker and only "Modtime", we store File info descriptors before running a command and compare it with after running the command.
We don't rely on creating hashes for file information as it has been identified as a bottle neck.
See graph
As the number of files increase, time spent in hashing increases