Skip to content
This repository was archived by the owner on Jun 3, 2025. It is now read-only.

feat: upgrade go-git#1319

Merged
tejal29 merged 1 commit intoGoogleContainerTools:masterfrom
caarlos0:go-git
Jul 29, 2020
Merged

feat: upgrade go-git#1319
tejal29 merged 1 commit intoGoogleContainerTools:masterfrom
caarlos0:go-git

Conversation

@caarlos0
Copy link
Copy Markdown
Contributor

Description

https://github.com/src-d/go-git was deprecated, the new repo is https://github.com/go-git/go-git.

This PR upgrades from the older to the new.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Adds integration tests if needed.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

Release Notes

Examples of user facing changes:
- upgrades go-git from v4 to v5.

Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
@googlebot googlebot added the cla: yes CLA signed by all commit authors label Jun 15, 2020
@caarlos0 caarlos0 mentioned this pull request Jun 15, 2020
4 tasks
@caarlos0
Copy link
Copy Markdown
Contributor Author

I would also say maybe delete the vendor folder and use just go.mod and go.sum, so the diffs are nicer? 🤔

@tejal29
Copy link
Copy Markdown
Contributor

tejal29 commented Jul 28, 2020

I would also say maybe delete the vendor folder and use just go.mod and go.sum, so the diffs are nicer? 🤔

The reason we use vendor mode is make sure travis jobs don't download all the dependencies and have faster run time.

@tejal29 tejal29 closed this Jul 28, 2020
@tejal29 tejal29 reopened this Jul 28, 2020
@tejal29 tejal29 merged commit a47a78e into GoogleContainerTools:master Jul 29, 2020
@caarlos0 caarlos0 deleted the go-git branch July 29, 2020 16:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes CLA signed by all commit authors kokoro:run

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants