Skip to content
This repository was archived by the owner on Jun 3, 2025. It is now read-only.

Added integration test for multi level argument#1285

Merged
tejal29 merged 1 commit intoGoogleContainerTools:masterfrom
antechrestos:fix/image_argument_name
Jun 4, 2020
Merged

Added integration test for multi level argument#1285
tejal29 merged 1 commit intoGoogleContainerTools:masterfrom
antechrestos:fix/image_argument_name

Conversation

@antechrestos
Copy link
Copy Markdown
Contributor

@antechrestos antechrestos commented May 24, 2020 •
edited
Loading

Description

Back in the time, @orisano submitted a fix for something kaniko could not handle:

ARG TAG=1.2
ARG IMAGE=my-image:${TAG}
FROM ${IMAGE}

In the meantime, this fix has been solved by a connected fix. This change only provides an integration test describing the expected behaviour of the previous issue noticed by @orisano

Submitter Checklist

  • Includes unit tests: Not needed
  • Adds integration tests if needed.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

Release Notes

None

@antechrestos
Added integration test for multi level argument
3462b75 
Added integration test to check that following pattern is supported

ARG TAG=1.2
ARG IMAGE=my-image:${TAG}
FROM ${IMAGE}
...
@googlebot googlebot added the cla: yes CLA signed by all commit authors label May 24, 2020
@tejal29 tejal29 merged commit 8074a70 into GoogleContainerTools:master Jun 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@tejal29 tejal29 tejal29 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes CLA signed by all commit authors

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@antechrestos @tejal29 @googlebot