This repository was archived by the owner on Jun 3, 2025. It is now read-only.
Add ability to set git auth token using environment variables#1263
Merged
tejal29 merged 1 commit intoGoogleContainerTools:masterfrom May 20, 2020
yorinasub17:git-auth-token-env
Merged
Add ability to set git auth token using environment variables#1263tejal29 merged 1 commit intoGoogleContainerTools:masterfrom yorinasub17:git-auth-token-env
tejal29 merged 1 commit intoGoogleContainerTools:masterfrom
yorinasub17:git-auth-token-env
Conversation
Currently the only way to set the git auth is by including it in the context git URL. This can be problematic for certain environments such as ECS where the command args for are stored in logs. Introduces updates to allow setting the authentication info using the environment variables `GIT_USERNAME` and `GIT_PASSWORD`.
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Contributor
Author
|
@googlebot I signed it! |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
tejal29
reviewed
May 19, 2020
Contributor
tejal29
left a comment
There was a problem hiding this comment.
Thank you for your PR!
One questions about usability.
tejal29
approved these changes
May 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently the only way to set the git auth is by including it in the context git URL. This can be problematic for certain environments such as ECS where the command args are stored in logs. This changeset introduces updates to allow setting the authentication info using the environment variables
GIT_USERNAMEandGIT_PASSWORD.Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
NOTE: I didn't add an integration test for this change given that it requires real git credentials with a private git repo to fully test. If the maintainers have ideas for how to do this, happy to attempt an implementation. FWIW, I ran this manually after creating a new container and it worked perfectly:
Reviewer Notes
Release Notes
Describe any changes here so maintainer can include it in the release notes, or delete this block.