Skip to content
This repository was archived by the owner on Jun 3, 2025. It is now read-only.

Add retries to image push.#1258

Merged
tejal29 merged 2 commits intoGoogleContainerTools:masterfrom
mitchfriedman:push-retries
May 19, 2020
Merged

Add retries to image push.#1258
tejal29 merged 2 commits intoGoogleContainerTools:masterfrom
mitchfriedman:push-retries

Conversation

@mitchfriedman
Copy link
Copy Markdown
Contributor

This uses the default provided retry transport by
go-containerregistry as this originally had no retries
built in.

This is useful to avoid intermittent failures of image
registries when returning a retryable status code.

No Issue number.

Description

This uses the default provided retry transport by
go-containerregistry as this originally had no retries
built in.

This is useful to avoid intermittent failures of image
registries when returning a retryable status code.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Adds integration tests if needed.

See the contribution guide for more details.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

Release Notes

All image pushes will now include retries with exponential backoff to avoid intermittent failures of registries.

@googlebot
Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no CLA not signed by all commit authors label May 8, 2020
@mitchfriedman
Copy link
Copy Markdown
Contributor Author

@googlebot I signed it!

@googlebot
Copy link
Copy Markdown

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes CLA signed by all commit authors and removed cla: no CLA not signed by all commit authors labels May 8, 2020
@mitchfriedman mitchfriedman force-pushed the push-retries branch 2 times, most recently from 3b557ac to 11ad9cc Compare May 8, 2020 12:49
This uses the default provided retry transport by
go-containerregistry as this originally had no retries
built in.

This is useful to avoid intermittent failures of image
registries when returning a retryable status code.
@tejal29
Copy link
Copy Markdown
Contributor

tejal29 commented May 19, 2020

tried it on my branch and it works.

@tejal29 tejal29 merged commit 6dfbdae into GoogleContainerTools:master May 19, 2020
@mitchfriedman mitchfriedman deleted the push-retries branch May 20, 2020 07:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes CLA signed by all commit authors

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants