upgrade go container registry to latest master

[tejal29]

Fixes #1144

Ran

go get -u github.com/google/go-containerregistry
go mod tidy

[tejal29]

@mattmoor Feel free to build the kaniko executor image with the instructions below to proceed with your testing.

REGISTRY=<you registry> make images

[mattmoor]

Things look kinda broken. Should I wait?

[tejal29]

Things look kinda broken. Should I wait?

yep sorry, i missed to add the vendor/modules.txt changes.

[tejal29]

hmm @samos123 have you seen this failure before https://travis-ci.org/github/GoogleContainerTools/kaniko/jobs/664165999?utm_medium=notification&utm_source=github_status?

[samos123]

it shouldn't have run K8s tests in that test run, for some reason the TestK8s wasn't excluded correctly. I'm looking into it more.

[samos123]

It's weird, this PR worked fine and also ran K8s tests separately: https://travis-ci.org/github/GoogleContainerTools/kaniko/builds/664580845?utm_source=github_status&utm_medium=notification. So not sure what's different here and why -list=Test is not returning the correct output...

[samos123]

I restarted that specific job and it now succeeded, for some reason the make integration-test-misc script ran all tests instead of only the misc tests and I still don't know why.

[mattmoor]

@tejal29 if this is ready for me to try out, I will do that tomorrow?

[mattmoor]

@tejal29 tl;dr success!

I built this image and copied it to docker.io/mattmoor/kaniko:tejal and ran it via the Tekton task on EKS with the following setup:

# Cluster must have oidc enabled:
eksctl utils associate-iam-oidc-provider --name knative-aws --approve

# Create service account with:
eksctl create iamserviceaccount \
  --name builder \
  --namespace default \
  --cluster knative-aws \
  --attach-policy-arn arn:aws:iam::aws:policy/AmazonEC2ContainerRegistryPowerUser \
  --approve

I then ran the Tekton TaskRun as the service account builder that the above creates, and it worked great!

[tejal29]

great Thanks @mattmoor. I will probably release this in v0.20.0 and let you know when its released.

[mattmoor]

Perfect, thanks!

[mattmoor]

Maybe worth a PR to the tekton Catalog when that comes out? tektoncd/catalog#235