This repository was archived by the owner on Jun 3, 2025. It is now read-only.
Add more tests for Copy and some fixes.#1114
Merged
tejal29 merged 6 commits intoGoogleContainerTools:masterfrom Mar 10, 2020
Merged
Add more tests for Copy and some fixes.#1114tejal29 merged 6 commits intoGoogleContainerTools:masterfrom
tejal29 merged 6 commits intoGoogleContainerTools:masterfrom
Conversation
tejal29
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes to #1111 , #1110
In #1111, @gilbsgilbs metioned, copy symlink files should not be evaluated.
I started testing what
docker builddoes and founddocker buildcreates symlinks when copying a single file which is a symlinksee Dockerfile COPY from image resolves symbolic links moby/moby#40449
docker buildpreserves the symlink when copying a dir.Kaniko, copy command was always creating a regular file.
While adding tests for
copyCommandi found few issues.destwas a directory in the context workspace, it wasn't identified as dir.errors.Wrapthat i found while debuging issues.Please see all the scenarios tested with docker build here #1111 (comment)