This repository was archived by the owner on Jun 3, 2025. It is now read-only.
remove build args from composite key and replace all build args#1085
Merged
tejal29 merged 6 commits intoGoogleContainerTools:masterfrom Mar 17, 2020
Merged
Conversation
…e adding command to the cache
… into rm_buildargs_from_cache_key
cvgw
reviewed
Mar 3, 2020
Contributor
|
Would you mind expanding the |
cvgw
reviewed
Mar 3, 2020
Contributor
cvgw
left a comment
There was a problem hiding this comment.
Few questions and more tests
tejal29
commented
Mar 4, 2020
Contributor
Author
tejal29
left a comment
There was a problem hiding this comment.
Answering comments
4bf24ed to
b9f4c4b
Compare
Contributor
Author
|
@cvgw Please take another look! |
cvgw
approved these changes
Mar 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1008
Description
In this change, we remove all the
build-argsbeing added to composite key.With
--cacheflag true, kaniko will try to optimize the builds. It will execute all the metadata command like "ENV", "ARG" and update theconfig.Envto find dependencies between stage.It discards the updated config changes after the optimize phase.
In this PR, I added a change
This will ensure, only layers which actually use the
ARGwill change ifARGvalue changes.Added tests for the same.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Reviewer Notes
Release Notes
Describe any changes here so maintainer can include it in the release notes, or delete this block.