Skip to content
This repository was archived by the owner on Jun 3, 2025. It is now read-only.

set log format using a flag#1031

Merged
tejal29 merged 1 commit intoGoogleContainerTools:masterfrom
osela:log-format
Feb 6, 2020
Merged

set log format using a flag#1031
tejal29 merged 1 commit intoGoogleContainerTools:masterfrom
osela:log-format

Conversation

@osela
Copy link
Copy Markdown
Contributor

@osela osela commented Feb 6, 2020

Fixes #1029

Description

This PR adds a log-format flag to make users' life easier when using log collectors like fluentd or in other scenarios where logs are parsed.
The flag supports 3 options:

  • "text" - standard text format
  • "color" - colored text format (default - to keep existing behavior)
  • "json"

As part of the change I introduced a new logging package to hold all logic that deals with logging.

As the logic is mostly inside main I didn't find much value for unit tests, but I can add them if you insist :)

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Adds integration tests if needed.

See the contribution guide for more details.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

Release Notes

Describe any changes here so maintainer can include it in the release notes, or delete this block.

- Add log-format flag

@googlebot
Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no CLA not signed by all commit authors label Feb 6, 2020
@osela
Copy link
Copy Markdown
Contributor Author

osela commented Feb 6, 2020

@googlebot I signed it!

@googlebot
Copy link
Copy Markdown

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes CLA signed by all commit authors and removed cla: no CLA not signed by all commit authors labels Feb 6, 2020
@tejal29
Copy link
Copy Markdown
Contributor

tejal29 commented Feb 6, 2020

@osela Please add bioler plate license code to newly added go file.

Thanks!

Comment thread pkg/logging/logging.go Outdated
Copy link
Copy Markdown
Contributor

@tejal29 tejal29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 small nit.

  1. Add license to pkg/logging/logging.go
  2. Add actionable error message.

@tejal29 tejal29 self-assigned this Feb 6, 2020
Comment thread pkg/logging/logging.go Outdated
@tejal29
Copy link
Copy Markdown
Contributor

tejal29 commented Feb 6, 2020

restarted the Travis build. Failed due to random docker install error.

@tejal29 tejal29 merged commit 03f2ac4 into GoogleContainerTools:master Feb 6, 2020
@cvgw cvgw mentioned this pull request Feb 7, 2020
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes CLA signed by all commit authors kokoro:run

Projects

None yet

Development

Successfully merging this pull request may close these issues.

better logging format

3 participants