This repository was archived by the owner on Jun 3, 2025. It is now read-only.
set log format using a flag#1031
Merged
tejal29 merged 1 commit intoGoogleContainerTools:masterfrom Feb 6, 2020
Merged
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Contributor
Author
|
@googlebot I signed it! |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Contributor
|
@osela Please add bioler plate license code to newly added go file. Thanks! |
tejal29
reviewed
Feb 6, 2020
tejal29
suggested changes
Feb 6, 2020
Contributor
tejal29
left a comment
There was a problem hiding this comment.
2 small nit.
- Add license to pkg/logging/logging.go
- Add actionable error message.
tejal29
reviewed
Feb 6, 2020
Contributor
|
restarted the Travis build. Failed due to random docker install error. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1029
Description
This PR adds a
log-formatflag to make users' life easier when using log collectors like fluentd or in other scenarios where logs are parsed.The flag supports 3 options:
As part of the change I introduced a new
loggingpackage to hold all logic that deals with logging.As the logic is mostly inside
mainI didn't find much value for unit tests, but I can add them if you insist :)Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Reviewer Notes
Release Notes
Describe any changes here so maintainer can include it in the release notes, or delete this block.