Allow contributors to launch integration tests against local registry

[antechrestos]

Fixes #1012

Description

This change allows contributors to launch integration tests with a local registry.

The idea is to check whether IMAGE_REPO parameter and

• if it starts with gcr.io, keep the previous thing
• if it starts with anything else, the program will crawl through dockerfiles, save them as temporary files, import the based gcr.io public images and push them to the target repo then launch the test. The rollback of savec files is made as a defer function

Please also note that I isolated the code of test launching in a dedicated function as os.Exit and defer cannot be mixed (as os.Exit exists without calling defered functions).

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Includes [unit tests] Not needed
• Adds integration tests Not needed

See the contribution guide for more details.

Reviewer Notes

• The code flow looks good.
• Unit tests and or integration tests added.

[antechrestos]

@tejal29 can I have the kokoro result?
Isn't any way to make him post the result in the discussions? Since it is able to remove a label, it should be able to post a message with an attachment I guess

[samos123]

Nice pull request. Significant improvement over how it was before. We're planning to get rid of Kokoro since Travis CI seems to be doing the job well enough and has public build logs.

I don't know why Kokoro is failing. @tejal29 can you take a look at why Kokoro is failing? this is the short error log:

    --- FAIL: TestRun/test_Dockerfile_test_hardlink (53.80s)
        cmd.go:41: [container-diff diff --no-cache daemon://gcr.io/kaniko-test/docker-dockerfile_test_hardlink gcr.io/kaniko-test/kaniko-dockerfile_test_hardlink -q --type=file --type=metadata --json]
        cmd.go:42: fatal error: concurrent map iteration and map write

[antechrestos]

@samos123 The issue you point must be the one @cvgw posted

[antechrestos]

@samos123 I've submitted a fix

[samos123]

Ah so we should wait for a new container-diff binary that includes that fix right? Either way, I've triggered kokoro just now to run again. I think it's safe to ignore kokoro in this case but let's wait for @cvgw or @tejal29 feedback.

[antechrestos]

@samos123 Luckily (for me) kokoro run successfully 😄

[tejal29]

with nits.

[antechrestos]

@tejal29 done.

Other point, the integration test TestRun/test_Dockerfile_test_copy_symlink has random behaviour. I don't know why but it passed the first time, then I had to repush cause my code was not well formatted (one excessive space), then it failed twice and succeeded the third time.

The two failure were due to

--- FAIL: TestRun/test_Dockerfile_test_copy_symlink (5.85s)

        integration_test.go:208: diff = [

              {

                "Image1": "localhost:5000/docker-dockerfile_test_copy_symlink",

                "Image2": "localhost:5000/kaniko-dockerfile_test_copy_symlink",

                "DiffType": "File",

                "Diff": {

                  "Adds": [

                    {

                      "Name": "/tmp/link",

                      "Size": -1

                    }

                  ],

                  "Dels": null,

                  "Mods": [

                    {

                      "Name": "/tmp",

                      "Size1": 6,

                      "Size2": 11

                    }

                  ]

                }

              },

              {

                "Image1": "localhost:5000/docker-dockerfile_test_copy_symlink",

                "Image2": "localhost:5000/kaniko-dockerfile_test_copy_symlink",

                "DiffType": "Metadata",

                "Diff": {

                  "Adds": [],

                  "Dels": []

                }

              }

            ]

        integration_test.go:211: []integration.diffOutput differ (-got, +want):   []integration.diffOutput{

              	{

              		Image1:   "localhost:5000/docker-dockerfile_test_copy_symlink",

              		Image2:   "localhost:5000/kaniko-dockerfile_test_copy_symlink",

              		DiffType: "File",

              		Diff: &integration.fileDiffResult{

            - 			Adds: []integration.fileDiff{{Name: "/tmp/link", Size: -1}},

            + 			Adds: nil,

              			Dels: nil,

              		},

              	},

              	{Image1: "localhost:5000/docker-dockerfile_test_copy_symlink", Image2: "localhost:5000/kaniko-dockerfile_test_copy_symlink", DiffType: "Metadata", Diff: &integration.metaDiffResult{Adds: []string{}, Dels: []string{}}},

              }

[antechrestos]

@tejal29 looks like you fixed the issue. I've rebased my work and it passed directly. I hope it was not due to luck 😏 .

[tejal29]

Thank you much!