Skip to content

Update save_data_batch_writes.go #5365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

asoto31
Copy link

@asoto31 asoto31 commented Aug 13, 2025

client.Batch() is deprecated: https://pkg.go.dev/cloud.google.com/go/firestore#Client.Batch

Instead client.BulkWriter() should be documented: https://pkg.go.dev/cloud.google.com/go/firestore#Client.BulkWriter

Description

Fixes # b/255272655

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

@asoto31 asoto31 requested review from a team as code owners August 13, 2025 18:17
Copy link

google-cla bot commented Aug 13, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Aug 13, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @asoto31, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates a Go sample for Google Cloud Firestore to reflect current best practices by replacing a deprecated API call. Specifically, it migrates the batchWrite function from using the older client.Batch() method to the recommended client.BulkWriter(ctx) for performing batch writes, ensuring the sample remains up-to-date and functional with the latest client library.

Highlights

  • API Usage Update: The batchWrite function in the firestore/save_data_batch_writes.go sample has been updated to use client.BulkWriter(ctx) instead of the deprecated client.Batch() method.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly updates the deprecated client.Batch() to client.BulkWriter(). However, this change introduces a compilation error because the API for BulkWriter is different from WriteBatch. Specifically, BulkWriter does not have a Commit method, which is used later in the function. My review includes a detailed comment on how to fix this and other related considerations for using BulkWriter correctly.

Copy link
Author

@asoto31 asoto31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review and approve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant