Skip to content

chore: Bump supported golang version in Quick Start Code Samples from 1.23 to 1.24 #5357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

Nishi-1412
Copy link

No description provided.

@Nishi-1412 Nishi-1412 requested review from a team as code owners July 31, 2025 07:10
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jul 31, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @Nishi-1412, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on a routine maintenance update, bringing several Go code samples and their associated deployment configurations up to date with the Go 1.24 runtime release. The changes ensure that these samples leverage the latest stable version of Go, maintaining their relevance and functionality within the Google Cloud Platform ecosystem.

Highlights

  • Go Version Updates: Updated the specified Go version from 1.23 to 1.24 across various go.mod files in different sample directories, ensuring compatibility with the latest Go runtime.
  • App Engine Configuration Updates: Modified app.yaml files for both App Engine standard and flexible environments to reflect the new Go 1.24 runtime, specifically changing runtime: go123 to runtime: go124 and runtime_version: 1.23 to runtime_version: 1.24.
  • Dockerfile Base Image Update: Updated the base Docker image for the run/helloworld sample from golang:1.23-bookworm to golang:1.24-bookworm, aligning the container build environment with Go 1.24.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly updates the Go runtime version to 1.24 for several code samples across App Engine, Cloud Functions, and Cloud Run. The changes in app.yaml, go.mod, and Dockerfile files are accurate and consistent with the goal of the PR.

However, the update appears to be incomplete. I've noticed that several parent go.mod files still reference the older Go version (go 1.23.0). To ensure consistency across the entire repository and prevent potential issues with tooling, I recommend also updating the following files to go 1.24.0:

  • appengine/go.mod
  • functions/go.mod
  • run/go.mod

Once these files are included, this PR will be a complete and consistent update for the Go 1.24 runtime.

@Nishi-1412 Nishi-1412 changed the title Go 1.24 Runtime Release Code Samples update chore: Bump supported golang version from 1.23 to 1.24 Jul 31, 2025
@Nishi-1412 Nishi-1412 changed the title chore: Bump supported golang version from 1.23 to 1.24 chore: Bump supported golang version in Quick Start Code Samples from 1.23 to 1.24 Jul 31, 2025
@Nishi-1412 Nishi-1412 requested a review from a team as a code owner July 31, 2025 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant